Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will degrade performance by 10.2%
Performance Changes
Comparing 
Footnotes
|
gatesn
changed the title
gatesn
force-pushed
the
ngates/execution-4c
branch
from
5fe80df to
12a70d5
Compare
gatesn
force-pushed
the
ngates/execution-3
branch
from
4223d1f to
2b9697c
Compare
gatesn
force-pushed
the
ngates/execution-4c
branch
3 times, most recently
from
24721b7 to
d825820
Compare
gatesn
force-pushed
the
ngates/execution-3
branch
from
5cd1e99 to
6c8dcdc
Compare
Replace recursive child.execute() calls with ExecutionStep returns in Slice, Filter, Masked, FoR, and ZigZag vtables. Each now checks if its child is already in the needed form (canonical/primitive/constant) and returns Done directly, or returns ExecuteChild(0)/ColumnarizeChild(0) to let the scheduler handle child execution iteratively. Also handles ConstantArray children explicitly to prevent infinite loops in the scheduler (since constants are already columnar and won't be re-executed). FoR decompress is split into try_fused_decompress and apply_reference for reuse without recursive execution. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Convert Dict, ALP-RD, DecimalByteParts, and Zstd VTable::execute implementations to return ExecutionStep instead of recursively calling execute on children. Each encoding checks if children are already in the expected form (Primitive/Canonical/Constant) before proceeding, returning ExecuteChild(n) to let the scheduler handle child execution. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… 4d) Convert the last two VTable::execute implementations that had recursive execute calls. SharedVTable now checks if current array (cached or source) is already columnar, otherwise returns ExecuteChild(0). ZstdBuffersVTable decompresses and returns Done(inner_array), letting the scheduler handle further execution of the decompressed result. Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gatesn
force-pushed
the
ngates/execution-4c
branch
from
d825820 to
2f987cf
Compare
gatesn
force-pushed
the
ngates/execution-3
branch
from
6c8dcdc to
b5b1652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #000
Testing